https://bugs.kde.org/show_bug.cgi?id=362805
--- Comment #19 from David Faure <[email protected]> --- Michael Pyne's comment https://phabricator.kde.org/D4335 says otherwise. I'm afraid we have to keep the current mess for compat reasons. Some distros (debian, neon, probably opensuse?) have applied the patch that tests for little endian [1]. Others (arch, upstream KDE) are doing 0==0 in that #if (or 1==1 with my recent commit to silence -Wundef). In both cases we go into those #if, on little endian machines. I believe the original intent (see the old code at [2]) was to NOT go into those #if (which were for big endian) but that ship has sailed. Changing that would break all wallets. On big endian, though, IIUC we have the choice between broken-unittest (without the patch) and broken-for-existing-users (with the patch). No good solution :( [1] https://packaging.neon.kde.org/kde/kwallet.git/tree/debian/patches/blowfish_endianess.diff?h=Neon/unstable&id=572447bcb13e5f36247b3872a60d2959a3f82e12 [2] https://cgit.kde.org/kde-runtime.git/tree/kwalletd/backend/blowfish.cc?id=a6c3e399e8674914ccde5d80710de866cbb700da Please correct me if I'm wrong in any of this. What a mess! -- You are receiving this mail because: You are watching all bug changes.
