https://bugs.kde.org/show_bug.cgi?id=423195
--- Comment #12 from Will Schmidt <will_schm...@vnet.ibm.com> --- (In reply to Julian Seward from comment #11) > (In reply to Carl Love from comment #5) > > Created attachment 130176 [details] > > Initial load and store instruction tests > > > > 0004-Initial-ISA-3.1-instruction-tests.patch > > > > Testsuite for new instructions > > diff --git a/none/tests/ppc64/isa_3_1_helpers.h > b/none/tests/ppc64/isa_3_1_helpers.h > new file mode 100644 > index 000000000..d6f2f9878 > --- /dev/null > +++ b/none/tests/ppc64/isa_3_1_helpers.h > > This seems like a lot of code (functions) to put in a .h file. Should this > stuff be in a .c > file instead? Probably yes. I'm prettu sure we have a similar scenario with the existing ppc64_helpers.h ; i'll do a lookover and see if that can be fixed up too. > > ---- > > new files: > none/tests/ppc64/test_isa_3_1_RT.c > none/tests/ppc64/test_isa_3_1_XT.c > none/tests/ppc64/test_isa_3_1_RT.c > none/tests/ppc64/test_isa_3_1_XT.c > > These are GPL 2-only licensed. I'd prefer that they are licensed "2 or any > later version" since > that is what the project requests. See the top level README file. That shouldn't be a problem. I believe I started with one of the existing tests for those, so we probably have something else existing with the GPL 2 license. I'll poke around a bit and see if I can confirm the origins of that one too. Thanks for the review. -- You are receiving this mail because: You are watching all bug changes.
