https://bugs.kde.org/show_bug.cgi?id=419170

Nicolas Fella <nicolas.fe...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/fram
                   |                            |eworks/purpose/commit/b7e6e
                   |                            |9afa5db0f789f9ef3c831eba5e3
                   |                            |98764371

--- Comment #6 from Nicolas Fella <nicolas.fe...@gmx.de> ---
Git commit b7e6e9afa5db0f789f9ef3c831eba5e398764371 by Nicolas Fella.
Committed on 28/08/2020 at 10:37.
Pushed by nicolasfella into branch 'master'.

Rework job view handling

The job view handling is a large chunk of quite imperative QML code that is
hard to maintain. It also seems to suffer from QML/C++ ownership issues that
result in crashes.

This patch introduces a new JobView component that does the job visualization.
Internally it uses a new JobController C++ class that is responsible for
tracking the job state.

JobDialog and AlternativesView are ported to use it.

Visually the end result is similar, except for the running job aspect. Instead
of the de-facto not working progress bar a BusyIndicator is used.

M  +1    -2    README.md
M  +1    -0    src/CMakeLists.txt
M  +1    -1    src/configuration.h
A  +99   -0    src/jobcontroller.cpp     [License: LGPL(v2.1+)]
A  +72   -0    src/jobcontroller.h     [License: LGPL(v2.1+)]
M  +12   -57   src/quick/AlternativesView.qml
A  +111  -0    src/quick/JobView.qml     [License: LGPL(v2.1+)]
D  +0    -48   src/quick/PurposeWizard.qml
D  +0    -54   src/quick/RunningJob.qml
M  +3    -2    src/quick/purposequickplugin.cpp
M  +1    -2    src/quick/qmlfiles.qrc
M  +16   -78   src/widgets/JobDialog.qml
M  +6    -4    src/widgets/menu.cpp

https://invent.kde.org/frameworks/purpose/commit/b7e6e9afa5db0f789f9ef3c831eba5e398764371

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to