https://bugs.kde.org/show_bug.cgi?id=425948
--- Comment #7 from Ahmad Samir <[email protected]> --- (In reply to Harald Sitter from comment #6) > Cool beans. > > One could argue there should be runtime validation for this in StatJob. > If a :internet slave sets UDS_LOCAL_PATH that seems fairly indicative of > using the wrong class. Excellent point; it also solves an issue of StatJob behaving differently based on whether you call: - KIO::mostLocalUrl, if the protocol Class isn't :local the job is cancelled, UDS_LOCAL_PATH is never looked at - KIO::stat/statDetails then job->statResult(), the Class isn't checked and UDS_LOCAL_PATH is used StatJob should be consistent (that issue made me go in circles for a while, where it didn't work if the code in kdeconnect used KRun which went through KIOExec path (uses KIO::mostLocalUrl); and worked if I changed kdeconnect to use OpenUrlJob instead of KRun, the former uses StatJob::statDetails). I'll see what I can do about that and submit an MR. Thanks :) -- You are receiving this mail because: You are watching all bug changes.
