https://bugs.kde.org/show_bug.cgi?id=364261
Mauro Carvalho Chehab <mche...@osg.samsung.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #1 from Mauro Carvalho Chehab <mche...@osg.samsung.com> ---
(In reply to JanKusanagi from comment #0)
> Kaffeine 2.0.3 uses Breeze icons in the menus, even when system's configured
> iconset is Oxygen.
>
> I've found that in src/main.cpp, there is a function, iconThemeFunc() that
> seems to handle this.
>
> The function starts with this 'if' statement, on line 159 of current master:
>
> if ((QIcon::themeName() != QLatin1String("breeze")
> && QIcon::themeName() != QLatin1String("oxgen"))
> || QIcon::themeName().isEmpty()) {
>
> where we can see it looks for "oxgen" theme, instead of "oxygen", so it will
> always default to "breeze" ;)
Sorry for the typo.
> P.S.- I understand the decision to force either of these two iconsets, as
> stated right before that function:
> "// The icon Kaffeine needs are either at breeze or oxygen themes"
>
> but I really think this should be optional, or a recommendation, or
> something like that. I see no reason for people to have this program showing
> with a completely alien iconset (for them), just because it's assumed other
> iconsets are not complete enough.
>
> What do you think?
The problem is that this window really relies on icons:
https://mchehab.fedorapeople.org/kaffeine_screenshots/kaffeine_live_tv.png
For TV configuration, channel scanning, OPG, record schedule and Instant save:
src/dvb/dvbtab.cpp: QAction *channelsAction = new
QAction(QIcon::fromTheme(QLatin1String("video-television")), i18n("Channels"),
this);
src/dvb/dvbtab.cpp: QAction *epgAction = new
QAction(QIcon::fromTheme(QLatin1String("view-list-details")), i18n("Program
Guide"), this);
src/dvb/dvbtab.cpp: QAction *osdAction = new
QAction(QIcon::fromTheme(QLatin1String("dialog-information")), i18n("OSD"),
this);
src/dvb/dvbtab.cpp: QAction *recordingsAction = new
QAction(QIcon::fromTheme(QLatin1String("view-pim-calendar")),
src/dvb/dvbtab.cpp: instantRecordAction = new
QAction(QIcon::fromTheme(QLatin1String("document-save")), i18n("Instant
Record"), this);
src/dvb/dvbtab.cpp: QAction *configureAction = new
QAction(QIcon::fromTheme(QLatin1String("configure")),
If the above icons are not found, it will display names, instead, with reduces
a lot the size of the screen view. AFAICT, the above icons are present only on
Breeze or Oxygen.
An option would be to, instead, copy all icons that Kaffeine needs from Breeze
(or Oxygen) and installing them as hicolor to work as fallback while other
themes don't have those icons.
For now, I'll fix the typo.
--
You are receiving this mail because:
You are watching all bug changes.
