https://bugs.kde.org/show_bug.cgi?id=427858

Tymond <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/9a7910865
                   |                            |e06be82d2a10d044a6ec0c2f04d
                   |                            |ac99
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Tymond <[email protected]> ---
Git commit 9a7910865e06be82d2a10d044a6ec0c2f04dac99 by Agata Cacko.
Committed on 27/10/2020 at 14:58.
Pushed by tymond into branch 'master'.

Fix crash in Text Tool on double-click

Before this commit, if the user would double-click on the text shape
while using a text tool, it would first show an editor with an empty
text box, and then if the user does something else without changing the
content (like Save, or switch to SVG) which would trigger conversion
to shape or SVG, then Krita would crash.

It was caused by double-click causing three events to be fired:
- double-click
- mouse release
- another mouse release.
In all three cases showEditor() would be called, including
setInitialShape() function which is called inside.

This commit fixes this behaviour by checking if the editor is already
visible, and if yes, then not trying to set initial shape or show the
editor since it's not necessary anymore.

M  +4    -2    plugins/tools/svgtexttool/SvgTextTool.cpp

https://invent.kde.org/graphics/krita/commit/9a7910865e06be82d2a10d044a6ec0c2f04dac99

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to