https://bugs.kde.org/show_bug.cgi?id=428850

--- Comment #6 from Méven Car <meve...@gmail.com> ---
(In reply to WiseLord from comment #5)
> (In reply to Davide Gianforte from comment #4)
> > Thanks for the help Meven! I followed the code in Krusader, it starts from
> > DefaultFileSystem::refreshInternal, and in FileSystem::createFileItemFromKIO
> > we use KFileItem in
> > https://invent.kde.org/utilities/krusader/-/blob/master/krusader/FileSystem/
> > filesystem.cpp#L289 (as you said) to retrieve the filename with ::text(),
> > which returns UDS_DISPLAY_NAME while ::name() returns UDS_NAME. I think the
> > change will be limited to this line.
> 
> You seem to be right, Davide. I replaced "name()" with "text()" and the
> problem has gone.

Great !

I believe you meant "text()" to "name()".

```
-    const QString name = kfi.text();
+    const QString name = kfi.name();
    // ignore un-needed entries
    if (name.isEmpty() || name == "." || name == "..") {
        return nullptr; // <- will now return null for archive root
    }
```

Who will do the honor of opening the MR ?

(I can do it it if no one else wants to)

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to