https://bugs.kde.org/show_bug.cgi?id=429262
Bug ID: 429262
Summary: Import Python Plugins doesn't import all action files
Product: krita
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: Scripting
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
Created attachment 133408
--> https://bugs.kde.org/attachment.cgi?id=133408&action=edit
Three slots plugin (as an example/test file)
SUMMARY
Import Python Plugins plugin doesn't import all action files; it only import
the one that contains an action which name is exactly the same as the plugin.
It is a problem with those p0lugins that have multiple actions but those
actions don't activate the plugin itself but do something else. For example
ThreeSlots plugin https://github.com/DarkDefender/threeslots contains an action
file with three actions: "activate_slot_1", "..._2", "..._3", and none of those
actions are called the same way as the main plugin, so action file will be
skipped, even though it's necessary for the plugin to work correctly.
NOTE: there are more plugins like this; all "shortcuts-based" plugins have
actions files and the requirement that it needs to contain an action with the
same name as the name of the plugin is unclear and, in my opinion, uncalled
for.
STEPS TO REPRODUCE
1. Download ThreeSlots plugin.
2. Use Import Python Plugin to import it.
OBSERVED RESULT
There are no shortcuts to assign.
If you put the action files in [resource folder]/actions/, you will get the
shortcuts and it will work correctly.
EXPECTED RESULT
Import Python Plugin plugin imports all relevant action files.
NOTE
It looks like the plugin importer tries to be smart about it and be suitable to
import multiple plugins at once. I don't think there is a need for that, most
plugins come from github-like websites or just dropbox/gumroad websites in one
zip per one plugin.
SOFTWARE/OS VERSIONS
Krita
Version: 4.4.1
Languages: en_US, en, en_US, en, en_US, en, pl_PL, pl, pl_PL, pl
Hidpi: true
Qt
Version (compiled): 5.12.9
Version (loaded): 5.12.9
--
You are receiving this mail because:
You are watching all bug changes.
