https://bugs.kde.org/show_bug.cgi?id=431855
Ismael Asensio <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |5.80 Resolution|--- |FIXED Latest Commit| |https://invent.kde.org/fram | |eworks/kcmutils/commit/5a57 | |18b22a396d392df8241ef6e98b8 | |b6faca009 Status|ASSIGNED |RESOLVED --- Comment #10 from Ismael Asensio <[email protected]> --- Git commit 5a5718b22a396d392df8241ef6e98b8b6faca009 by Ismael Asensio. Committed on 11/02/2021 at 18:17. Pushed by iasensio into branch 'master'. Fix wrong margins on QML-based KCMs Previous layouting relied on the page GridLayout's spacing and global contents margins to set components spatially. This breaks for Qml-based KCMs, as the Qml component sets its own internal title, spacing and margins. Now, we remove the contents margins on Qml-based KCMs so the can expand to the edges, but keep them on QtWidget ones, so they remain visually unchanged. This enforces consistency between different standalone KCMs, systemsettings sidebar view and systemsettings icon view. It also removes an ugly extra pixel margin on the right side caused by the GridLayout spacing. Co-Authored by: ngraham FIXED-IN: 5.80 M +5 -1 src/kcmoduleproxy.cpp M +3 -2 src/kcmoduleqml.cpp M +22 -2 src/kcmultidialog.cpp https://invent.kde.org/frameworks/kcmutils/commit/5a5718b22a396d392df8241ef6e98b8b6faca009 -- You are receiving this mail because: You are watching all bug changes.
