https://bugs.kde.org/show_bug.cgi?id=355229
David Faure <fa...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |http://commits.kde.org/akon
| |adi/381acbc294dcecb0d4beb63
| |721080d231e4bca38
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from David Faure <fa...@kde.org> ---
Git commit 381acbc294dcecb0d4beb63721080d231e4bca38 by David Faure.
Committed on 05/07/2016 at 07:02.
Pushed by dfaure into branch 'master'.
Port StatisticsProxyModel to KExtraColumnsProxyModel.
* this fixes sibling() - the unittest confirmed Dan's assessment that
sibling() got broken for StatisticsProxyModel with Qt5.
* this reduces the number of dataChanged signals emitted by the proxy:
instead of dataChanged((row,0) (row,0)) + dataChanged((row,1) (row,3))
the proxy now emits dataChanged((row,0) (row,3)) directly
* I also removed the code emitting dataChanged for parent indexes,
the reasoning was "so that cumulative totals can be updated", but there
are no cumulative totals anywhere in this proxy (other than the tooltip).
* the awful model-index-struct-casting hack is no longer necessary,
the code is much simpler, there are now unittests (both here and for
the base class KExtraColumnsProxyModel in kitemmodels)...
M +1 -0 autotests/libs/CMakeLists.txt
A +241 -0 autotests/libs/statisticsproxymodeltest.cpp [License: LGPL
(v2+)]
A +79 -0 autotests/libs/test_model_helpers.h [License: LGPL (v2+)]
M +72 -279 src/core/models/statisticsproxymodel.cpp
M +9 -18 src/core/models/statisticsproxymodel.h
http://commits.kde.org/akonadi/381acbc294dcecb0d4beb63721080d231e4bca38
--
You are receiving this mail because:
You are watching all bug changes.
