https://bugs.kde.org/show_bug.cgi?id=437994

--- Comment #6 from Alvin Wong <al...@alvinhc.com> ---
So, the reason I assigned myself so quickly is that, some time ago I was
already working on some changes in my stash that would fix this exact issue.
But when I looked carefully again, it turns out there are actually more issues
with the language list than I originally thought, which means my changes are
incorrect.

... But let's not talk about those here.

For our Portuguese translations, there are `pt` and `pt_BR`. `pt_BR` is
obviously for Brazillian Portuguese, so I'm assuming `pt` is "Portugal"
Portuguese. The lazy way is to just show the language code in parentheses, and
this would work simply for disambiguating all languages, but it would not be
very user-friendly.

Upstream KConfigWidgets actually uses more info [1] to get the language name,
but this doesn't really work as we don't ship the `kf5_entry.desktop` files in
our releases.

For now, we can instead do this: If the language code contains an underscore,
we append the country name in parentheses. In fact I will commit this change
now. This doesn't resolve the other issues that I found, but I'll just leave
them for later.

[1]:
https://invent.kde.org/frameworks/kconfigwidgets/-/blob/40e36e9b255de3ec621d8531ef46daa3e1e5476b/src/klanguagebutton.cpp#L133

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to