https://bugs.kde.org/show_bug.cgi?id=365363

Wolfgang Bauer <wba...@tmo.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned-b...@kde.org     |cf...@kde.org
            Product|systemsettings              |frameworks-kiconthemes
          Component|kcm_icons                   |general
            Version|5.6.5                       |5.24.0
                 CC|                            |kdelibs-b...@kde.org

--- Comment #6 from Wolfgang Bauer <wba...@tmo.at> ---
Ok, I did some debugging myself, and this is the problem:
    // Check application specific config for a theme setting.
    KConfigGroup app_cg(KSharedConfig::openConfig(QString(),
KConfig::NoGlobals), "Icons");
    theme = app_cg.readEntry("Theme", QString());
    if (theme.isEmpty() || theme == QLatin1String("hicolor")) {
        // No theme, try to use Qt's. A Platform plugin might have set
        // a good theme there.
        theme = QIcon::themeName(); <---
    }
    if (theme.isEmpty() || theme == QLatin1String("hicolor")) {
        // Still no theme, try config with kdeglobals.
        KConfigGroup cg(KSharedConfig::openConfig(), "Icons");
        theme = cg.readEntry("Theme", QString());
    }
(that's in KIconTheme::current() )

If there is no application specific override, it tries to get the current theme
from QIcon::themeName() before it reads kdeglobals.
But for some reason, QIcon::themeName() still returns the old one, i.e. the
Plasma platform plugin apparently doesn't notice that the settings have been
changed.

Removing that line ("theme = QIcon::themeName();") "fixes" the problem in
systemsettings5.
I'm not sure that's the correct fix though, as it will prefer kdeglobals also
on other desktops.
Maybe the platform plugin should be fixed/improved instead...

Anyway, reassigning to kiconthemes for now, it's not a bug in
systemsettings/kcm_icons IMHO. Though maybe plasma-integration would be the
better component, I'm not sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to