https://bugs.kde.org/show_bug.cgi?id=364848
--- Comment #9 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov. Committed on 20/07/2016 at 14:00. Pushed by dkazakov into branch 'kazakov/memory-optimizations'. Don't keep the default tile data blocked from swapping Summary: We don't access the raw data of it usually. And is cases we do we should block it separately. This patch is needed to be able to migrate the leftover of tiles to the new pool when a document is closed. Release all the tile pools forcefully when a document is closed This approach is a bit hackish, but it is the best thing we can do. When the document is closed and the pool still contains a few tiles, we artificially "swap-out" the tiles into a QList, purge the data in the tile data pools and "swap-in" the tiles back. Surely, we will not get an ACM award for this solution, but at least it works ;) Related: bug 363334 Implement data pool for the chunks in openGL canvas updates This patch implements KisTextureTileInfoPool. A special object that keeps track of all the chunks allocated during the openGL canvas updates. This class is also capable of tracking multiple openGL tile sizes and color space pixel sizes. It should fix the most of the memory fragmentation problems, especially on Windows. Fix warning Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations Test Plan: Open any **huge image** in Krita and try to work with it, Krita should not consume more memory with time. The RAM shouldn't also grow with reopening the same large image multiple times. Well, it will grow anyway, but not much. Reviewers: rempt Subscribers: dkazakov Differential Revision: https://phabricator.kde.org/D2236 http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8 --- Comment #10 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit 5884065cb3fe96d294387e3e436c7b6be4da03a8 by Dmitry Kazakov. Committed on 20/07/2016 at 14:00. Pushed by dkazakov into branch 'kazakov/memory-optimizations'. Don't keep the default tile data blocked from swapping Summary: We don't access the raw data of it usually. And is cases we do we should block it separately. This patch is needed to be able to migrate the leftover of tiles to the new pool when a document is closed. Release all the tile pools forcefully when a document is closed This approach is a bit hackish, but it is the best thing we can do. When the document is closed and the pool still contains a few tiles, we artificially "swap-out" the tiles into a QList, purge the data in the tile data pools and "swap-in" the tiles back. Surely, we will not get an ACM award for this solution, but at least it works ;) Related: bug 363334 Implement data pool for the chunks in openGL canvas updates This patch implements KisTextureTileInfoPool. A special object that keeps track of all the chunks allocated during the openGL canvas updates. This class is also capable of tracking multiple openGL tile sizes and color space pixel sizes. It should fix the most of the memory fragmentation problems, especially on Windows. Fix warning Merge remote-tracking branch 'origin/master' into kazakov/memory-optimizations Test Plan: Open any **huge image** in Krita and try to work with it, Krita should not consume more memory with time. The RAM shouldn't also grow with reopening the same large image multiple times. Well, it will grow anyway, but not much. Reviewers: rempt Subscribers: dkazakov Differential Revision: https://phabricator.kde.org/D2236 http://commits.kde.org/krita/5884065cb3fe96d294387e3e436c7b6be4da03a8 -- You are receiving this mail because: You are watching all bug changes.
