https://bugs.kde.org/show_bug.cgi?id=433473

Mark Wielaard <m...@klomp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m...@klomp.org

--- Comment #2 from Mark Wielaard <m...@klomp.org> ---
I haven't reviewed the new/changed tests themselves.

But this is where you would introduce the new configure.ac CONFIG files for:

drd/tests/filter_error_count.in
drd/tests/filter_error_summary.in
drd/tests/filter_stderr.in
drd/tests/filter_stderr_and_thread_no_and_offset.in
drd/tests/filter_thread_no.in
drd/tests/filter_xml_and_thread_no.in

I would also add them with their full names in .gitignore. Using filter_* is
too broad IMHO.

Are you sure that the cleanup: rm -f vgcore.* in the .vgtest files is a good
idea? Do these tests deliberately dump core? If not I would keep the vgcore
files to investigate afterwards.

I assume the drd/tests/tc09_bad_unlock.stderr.exp-glibc2.8 and
drd/tests/tc23_bogus_condwait.stderr.exp-linux-x86 changes were because of the
line number shifts in the corresponding test files?

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to