https://bugs.kde.org/show_bug.cgi?id=441605
amyspark <a...@amyspark.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/885e62a63 |hics/krita/commit/222f78144
|383e5117a158b3c6601c910ce21 |82ca797148b757566dc153fcc25
|b2e6 |5d5a
--- Comment #7 from amyspark <a...@amyspark.me> ---
Git commit 222f7814482ca797148b757566dc153fcc255d5a by L. E. Segovia.
Committed on 21/10/2021 at 13:12.
Pushed by lsegovia into branch 'krita/5.0'.
KisAslLayerStyleSerializer: fix layer-local gradients load
In 2d426ac0b57ad8595a01b0c82d18633e4ec6060b, @dkazakov refactored the
load so that layer styles would insert their resources on global storage
instead of keeping them in their local stashes. However, this did not
take in account that layers can also have locally defined e.g.
gradients. These will not be found if the resource interface is
overriden because they are resident on the root layer's
localStrokeStorage.
Upon a complete review of the code, the true reason for this failure
lied not only in the (in)validity of the layer style, which I fixed in a
previous commit, but also on the fact that gradients and patterns are
uploaded *before* they are read (!!), in the embedded pattern
registration loop.
This commit fixes that by moving the two upload loops to inside the
layer style deserialization, and making sure they upload only missing
resources (to avoid accidentally quadratic behaviour).
CCMAIL: dimul...@gmail.com
CCMAIL: tamtamy.tym...@gmail.com
(cherry picked from commit 885e62a63383e5117a158b3c6601c910ce21b2e6)
M +4 -0 libs/image/kis_asl_layer_style_serializer.cpp
M +20 -16 plugins/impex/psd/psd_loader.cpp
https://invent.kde.org/graphics/krita/commit/222f7814482ca797148b757566dc153fcc255d5a
--
You are receiving this mail because:
You are watching all bug changes.
