https://bugs.kde.org/show_bug.cgi?id=433907
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/plasma-desktop/commit/b6 |ma/plasma-desktop/commit/ec
|3a6c9b16f261ecac99e5d1abbd7 |2d3d56a7eb0ac7bd6eb2a3fb860
|2c52349cb95 |38fad0f000e
--- Comment #38 from Nate Graham <n...@kde.org> ---
Git commit ec2d3d56a7eb0ac7bd6eb2a3fb86038fad0f000e by Nate Graham, on behalf
of Fushan Wen.
Committed on 16/11/2021 at 01:33.
Pushed by ngraham into branch 'master'.
taskmanager: Port PlasmaExtras.ScrollArea to PC3.ScrollView in GroupDialog
1. Port `PlasmaExtras.ScrollArea` to `PC3.ScrollView`, and port `Repeater` to
`ListView` so only visible tasks are loaded.
2. Rework activeTask mechanism to fit `ListView`, so the highlight can
be restored after opening the same textual list (`findActiveTaskIndex()`).
3. Drop `updateSize()` function because it's more distinct to use size
bindings, and the text width is updated by `updateMaxTextWidth()`.
4. Drop `attachModel()` function and set model property directly in
`ListView`.
5. Add `isGroupDialog` bool property to `MouseHandler` because
`ListView` uses `itemAt` instead of `childAt` to get the item at the
cursor position, so drag and drop still works.
6. Several hacks to prevent warning messages, including "Binding loop
detected" and "trying to show an empty dialog".
7. Add `iconMargin` and `labelMargin`, so those properties can be shared
between `Task` and `GroupDialog`.
M +61 -219 applets/taskmanager/package/contents/ui/GroupDialog.qml
M +7 -1 applets/taskmanager/package/contents/ui/MouseHandler.qml
M +6 -6 applets/taskmanager/package/contents/ui/Task.qml
M +2 -0 applets/taskmanager/package/contents/ui/code/layout.js
https://invent.kde.org/plasma/plasma-desktop/commit/ec2d3d56a7eb0ac7bd6eb2a3fb86038fad0f000e
--
You are receiving this mail because:
You are watching all bug changes.
