https://bugs.kde.org/show_bug.cgi?id=448118

            Bug ID: 448118
           Summary: PSD: KisAslLayerStyleSerializer puts null pointers in
                    the pattern store
           Product: krita
           Version: git master (please specify the git hash!)
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: File formats
          Assignee: krita-bugs-n...@kde.org
          Reporter: ha...@valdyas.org
  Target Milestone: ---

If the pattern referenced in a layer style in a psd file isn't found, the
pattern store will contain an empty pattern:

krita.general: WARNING: ASL style contains non-existent pattern reference!
Searching for uuid:  "bf565312-67b6-1177-9181-9d5762aa7056"  (name: 
"$$$/Patterns/Defaults/RightDiagonalLine1=Right Diagonal Line 1" )
krita.lib.resources: No MD5 for 0x55e04bb09890 "invalid"
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
QHash(("bf565312-67b6-1177-9181-9d5762aa7056_invalid",
QSharedPointer(0x55e04bb09890))("bf565312-67b6-1177-9181-9d5762aa7056",
QSharedPointer(0x0)))
Invalid or empty pattern QSharedPointer(0x0)
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: WARNING: ASL style contains non-existent pattern reference!
Searching for uuid:  "bf565312-67b6-1177-9181-9d5762aa7056"  (name: 
"$$$/Patterns/Defaults/RightDiagonalLine1=Right Diagonal Line 1" )
krita.lib.resources: No MD5 for 0x55e04606f4a0 "invalid"
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
krita.general: convertAndSetBlendMode: Curve conversion is not implemented yet
QHash(("bf565312-67b6-1177-9181-9d5762aa7056_invalid",
QSharedPointer(0x55e04606f4a0))("bf565312-67b6-1177-9181-9d5762aa7056",
QSharedPointer(0x0)))
Invalid or empty pattern QSharedPointer(0x0)

The psd decode code assumes that all patterns in the store are valid and no
nullptr. It's easy enough to check for that in the psd importer, but we
shouldn't put 0x0 in the pattern store...

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to