https://bugs.kde.org/show_bug.cgi?id=448087
--- Comment #7 from Andreas Grois <[email protected]> --- I think the first draft of the changes is ready for an initial review, in case you would like to merge them: https://invent.kde.org/sdk/rust-qt-binding-generator/-/merge_requests/2 It's still marked as WIP, because there are a few things that still need attention before merging is possible: - First of all: Do you actually want to merge that change? If not, I'm perfectly happy with having it on a separate branch. It's quite a breaking change after all, given it touches the function signature of all setters and some getters, so everyone switching to the changed version needs to update a lot of Rust code... - Only the generator and the tests have been changed up to now. I guess I should update Demo and Todos example as well? Just so the cmake build does actually work again, and to see if the changes cause any serious road-blocks missed by the tests. - What about the documentation? Should I update the code samples included in the Tutorial texts as well? Or add a note that the examples were written for version 0.3.6 and newer versions might require slightly different function signatures? - While speaking about version numbers: With this breaking change the version number should probably be incremented to 0.4.0, I guess? - When merging, the commits should probably be squashed. The main program always "worked" more or less, but the tests were most of the time in broken state, and neither Demo nor Example are currently compiling. -- You are receiving this mail because: You are watching all bug changes.
