https://bugs.kde.org/show_bug.cgi?id=449129
Oliver Kellogg <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit| |https://invent.kde.org/sdk/ | |umbrello/commit/9acd3b8418f | |9c1b5e77b4294ddebbe64757720 | |c9 Resolution|DUPLICATE |FIXED Version Fixed In| |2.33.80 (KDE releases | |22.03.80) --- Comment #2 from Oliver Kellogg <[email protected]> --- Git commit 9acd3b8418f9c1b5e77b4294ddebbe64757720c9 by Oliver Kellogg. Committed on 30/01/2022 at 21:27. Pushed by okellogg into branch 'master'. Fix crash importing Pascal code via import wizard: umbrello/umldoc.{h,cpp} - New function findDatatype(QString name, bool includeInactive) seeks the given name in the Datatypes folder and returns pointer to the UMLDatatype object if found, otherwise nullptr. - In function createDatatype return pointer to the UMLDatatype created. umbrello/codeimport/pascalimport.h - Prepare for reimplementing NativeImportBase function `split'. umbrello/codeimport/pascalimport.cpp - Add TODO note at function split(const QString&). - In function parseStmt : - Log a debug message showing the token currently being parsed along with its m_srcIndex and following token. - Add preliminary handling of "[". - On handling "function", "procedure", "constructor", "destructor", if m_klass is null then call skipStmt() before returning. - At start of handling m_section sect_TYPE, if m_klass is null then save return value from advance() to local QString rhsName for preserving the casing (which is lost in `keyword'). - Provide first implementation for handling datatypes. - On handling "At this point we need a class [...]" near end of function, - handle nullptr returned by Import_Utils::insertAttribute as a regular error and avoid dereferencing it; - handle nullptr returned by o->asUMLAttribute() as a regular error and avoid dereferencing it. This hunk is the actual crash fix. FIXED-IN:2.33.80 (KDE releases 22.03.80) M +62 -6 umbrello/codeimport/pascalimport.cpp M +2 -0 umbrello/codeimport/pascalimport.h M +28 -2 umbrello/umldoc.cpp M +2 -1 umbrello/umldoc.h https://invent.kde.org/sdk/umbrello/commit/9acd3b8418f9c1b5e77b4294ddebbe64757720c9 -- You are receiving this mail because: You are watching all bug changes.
