https://bugs.kde.org/show_bug.cgi?id=449539
Bug ID: 449539
Summary: ExpandableListItem: isEnabled property is redundant
and doesn't work the way it was intended to
Product: frameworks-plasma
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: components
Assignee: [email protected]
Reporter: [email protected]
CC: [email protected]
Target Milestone: ---
Created attachment 146207
--> https://bugs.kde.org/attachment.cgi?id=146207&action=edit
Plasma Vaults applet - wrong enabled state
SUMMARY
All QtQuick Items have built-in `enabled` property which comes for free out of
the box. Having a duplicating `isEnabled` property is redundant, unnecessary,
and it does not support implicit state inheritance (which allows to disable the
whole tree of Items just by «switching off» a top-level component with a single
`enabled = false`).
This property is only ever used in a single applet (namely, Vaults) under some
specific conditions (Error or
DeviceMissing state), and even then it allows too much interactions for such a
disabled list item. For example, as shown in the attached video, the main
action button is indeed disabled, but the list of additional actions is
expandable and they are individually clickable, which allowed me to attempt and
successfully mount a vault.
STEPS TO REPRODUCE
1. Make sure your Plasma Vault is in either or DeviceMissing state. Or just
recompile the plugin with vaultsmodel.cpp patched as `case VaultIsEnabled:
return false`.
2. Open «Vaults» applet's full representation (e.g. just click on its icon in
system tray).
3. Have at least one vault in the list (create a new one if necessary).
4. Click on Expand button on the right of a vault.
5. Click Unlock and/or Configure buttons that have appeared.
OBSERVED RESULT
Buttons are interactive.
EXPECTED RESULT
Buttons should be disabled just as the whole list item itself.
SOFTWARE/OS VERSIONS
Operating System: Arch Linux
KDE Plasma Version: 5.24.80
KDE Frameworks Version: 5.91.0
Qt Version: 5.15.2
Kernel Version: 5.16.4-arch1-1 (64-bit)
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 15.6 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 970M/PCIe/SSE2
git:
plasma-desktop: c2b4113722d395f1c7122689c119555f3ed7c0eb
plasma-workspace: a61b3faecb1e13c8100084f14e6646721c6e48bb
plasma-framework: 602ab69160de190eff7d9daa45ac7a9c0e489764
plasma-vault: 22d69fa28a562525b966327c3aacd489d80ecd84
--
You are receiving this mail because:
You are watching all bug changes.
