https://bugs.kde.org/show_bug.cgi?id=432093
--- Comment #20 from EDeadLock <maicolgabr...@hotmail.com> ---
(In reply to Ismael Asensio from comment #16)
> (In reply to EDeadLock from comment #13)
>
> > @@ -485,7 +487,7 @@ void ModuleView::stateChanged()
> > updatePageIconHeader(d->mPageWidget->currentPage());
> >
> > KCModuleProxy *moduleProxy =
> > d->mPages.value(d->mPageWidget->currentPage());
> > - d->mCustomHeader->setVisible(!moduleProxy ||
> > !moduleProxy->realModule()->inherits("KCModuleQml"));
> > + d->mCustomHeader->setVisible(false);
>
> Hi there! You were right in this line causing the bug.
>
> The reason you couldn't find "Header3" is because it is generated in QML by
> modules that have already been ported to use that technology.
Does this mean we have to port/update the modules to use this technology so
that QML generates the correct headers?
There is code
> to treat the three different cases (QML modules, QWidget modules when in
> Sidebar View and QWidget modules when in Icon View), but that code wasn't
> always being run, causing the bug.
>
> The code in this class in general has been suffering from small incremental
> changes which made it a little too un-manageable, so fixing one thing could
> break a different one. I hope with a little refactor this is sorted out and
> not many new surprises arise.
Thank you Ismael for the explanation.
I was able to test latest master (06df6b61) and I see that one of the bad
headers is gone (Header1) but we still have Header2 present and the correct
header3 is not yet shown. Small step in the right direction, again, thank you
so much. I assume we have to port/update the modules to use the newer
technology so that we get the correct header shown as I asked above. Anyway I
can help with this? Please let me know what I can do to help, best!
--
You are receiving this mail because:
You are watching all bug changes.
