https://bugs.kde.org/show_bug.cgi?id=445922

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/commit/f23f9a6d9
                   |                            |90ee978803deb3e3dcaa1e482b1
                   |                            |f9af
         Resolution|---                         |FIXED

--- Comment #21 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit f23f9a6d990ee978803deb3e3dcaa1e482b1f9af by Dmitry Kazakov.
Committed on 09/02/2022 at 14:00.
Pushed by dkazakov into branch 'master'.

Fix a crash when opening LS dialog with all patterns filtered-out

If the currently (globally) active tag filters out all the resources,
then the selectors may fail to activate a resource from the user's
preset/style and end up returning a null pointer.

This patch just moves the concept of a "hidden" selection from
KisResourceItemChooser to KisPatternChooser.

Steps to reproduce:

1) In the global pattern chooser create a new tag, don't add any patterns to
that, activate the tag
2) See that the pattern selector doesn't have a any resources in it
3) Open the Layer Styles dialog. Click on the bevel style. See the crash.

M  +3    -3    libs/ui/dialogs/kis_dlg_layer_style.cpp
M  +6    -3    libs/ui/widgets/kis_pattern_chooser.cc
M  +1    -1    libs/ui/widgets/kis_pattern_chooser.h
M  +4    -3    plugins/generators/pattern/kis_wdg_pattern.cpp
M  +3    -3    plugins/paintops/libpaintop/kis_texture_option.cpp

https://invent.kde.org/graphics/krita/commit/f23f9a6d990ee978803deb3e3dcaa1e482b1f9af

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to