https://bugs.kde.org/show_bug.cgi?id=435211

Albert Astals Cid <aa...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/game
                   |                            |s/picmi/commit/f8a03f1f98f9
                   |                            |288e6d6b6cd705a3f430511550c
                   |                            |f
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Albert Astals Cid <aa...@kde.org> ---
Git commit f8a03f1f98f9288e6d6b6cd705a3f430511550cf by Albert Astals Cid, on
behalf of Martin Walch.
Committed on 09/02/2022 at 21:38.
Pushed by aacid into branch 'master'.

Always mark full lines with wrong streak sizes as completely unsatisfied

Streak checks happen in normal and in reverse order. On full lines this
means that all streaks are matched twice against the solution, yielding
markers that may feel counter-intuitive.

In particular, a solution that consists of two identical sub-patterns is
marked as completely satisfied on a full line that contains the sub-pattern
only once. A board may even seem completely solved, while it is not.

To prevent this, extend the preliminary checks to completely reject full
lines with the wrong number of streaks.

M  +8    -2    src/logic/streaks.cpp

https://invent.kde.org/games/picmi/commit/f8a03f1f98f9288e6d6b6cd705a3f430511550cf

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to