https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #32 from Mark Wielaard <m...@klomp.org> ---
For "implement support for missing DW_LLE_* and DW_RLE_* values" the code looks
good.
But the error handling in get_debug_addr_entry looks off.
The second argument is DW_FORM form. But it is given either a DW_FORM, DW_LLE
or DW_LRE.
I think it would be better if the second argument would be a const HChar*.
And we introduce new functions:
const HChar* ML_(pp_DW_LLE) ( DW_LLE loc )
const HChar* ML_(pp_DW_RLE) ( DW_RLE range )
So get_debug_addr_entry can print the actual operator in the error message.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to