https://bugs.kde.org/show_bug.cgi?id=418312
Frédéric Brière <fbri...@fbriere.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/netw
| |ork/choqok/commit/2e6ac3ec1
| |f764d3bb58a0640a2fee060c58f
| |ad2c
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Frédéric Brière <fbri...@fbriere.net> ---
Git commit 2e6ac3ec1f764d3bb58a0640a2fee060c58fad2c by Frédéric Brière.
Committed on 21/06/2022 at 07:06.
Pushed by scarpino into branch 'master'.
Disconnect configChanged() signal from *Settings in QWidget-based dtors
Because the QWidget dtor will delete its children first, it is the
responsability of any subclass to disconnect any signal that might be
emitted as a result of a child's destruction. Otherwise, that signal
could end up attempting to invoke a method on the now-destroyed parent.
The ChoqokTabBar, QuickPost and TextEdit dtors put various settings in
AppearanceSettings or BehaviorSettings, which may end up triggering a
configChanged() signal. Therefore, all QWidget subclasses that have
connected this signal should disconnect it in their dtor.
(Technically, this is only required of *parents* of the above classes,
so it could be omitted from TextEdit. Still, better safe than sorry.)
M +5 -0 choqok/mainwindow.cpp
M +3 -0 libchoqok/ui/choqoktextedit.cpp
https://invent.kde.org/network/choqok/commit/2e6ac3ec1f764d3bb58a0640a2fee060c58fad2c
--
You are receiving this mail because:
You are watching all bug changes.
