https://bugs.kde.org/show_bug.cgi?id=455919
--- Comment #5 from Deif Lou <[email protected]> --- Well, that last comment just shows that the options are not clear enough. The "include surrounding regions" is different from the "include contour regions". I'll try to explain what kind of concepts one needs to have into account: * The enclosing region is the region the user makes to limit what shapes should be considered. * The contour of the enclosing region is just that, the limit between inside and outside of the enclosing region. * The closed, enclosed, regions, are those regions that can be delimited inside the enclosing region and that lie entirely inside that, that is, those that are selected and that do not touch the enclosing region contour. * "Include contour regions" refers to regions that can be selected given the options when using the "regions of specific color/transparent" or "all regions except specific color/transparent", but that touch the enclosing contour. By default those should not be selected, since they are not closed (since they touch the enclosing contour, part of them lie outside the enclosing region). The only reason I can remember I included this option was this: Imagine you have a colored lineart (say black) on a transparent layer. For example a character head with different areas such as face, hair, lips, etc.. Then, if you want to color the lines themselves instead of the inner regions, with different color that match the filling colors (a darker shade of skin tone for the lines of the face, or a darker tone for the hair lines, for example) you can just lock the alpha on the layer and then select and fill (or just use the shape brush) whatever portion of the line art you want filled. But if the "non-lineart" areas are not transparent (for example they are white or have already being filled with other colors) you can not rely on the "lock alpha" feature. And this is when the "include contour regions" can be useful. Basically, with that option selected, all the enclosed regions of the specific color will be filled, regardless of if they touch the enclosing contour or not. This alone is a very niche use case, since I think the better and less issue-prone approach would be to have the lineart on its own transparent layer. * When I refer to the surrounding regions, I mean those regions of the user-given color in the "regions surrounded by x" methods. Those can touch the enclosing contour or not. Imagine a set of white blobs with a black outline on a transparent layer, for example. You can select regions surrounded by black so the white part should be filled, and the black regions should remain black. If "include surrounding regions" is selected then the white interior and the black surrounding should be selected. But as I said, now I think that if "include surrounding regions" is selected, the same result in the 90%+ of the cases can be achieved by other modes, like "select all regions". I said 90%+ and not 100% just because I myself am not totally sure. It would need some exploration by the users. * If "include surrounding regions" is on, then the selected regions should be composed by all the closed regions that are totally inside of a region of the specified color, plus the surrounding region of the specified color itself. But if one of those composed regions touches the contour it is removed (only the resulting regions that lie totally inside the enclosing region are selected). Again, I think the "include surrounding regions" option can be removed (at least from the interface), and we'll see if there is requested in the future. The "include contour regions" I find more useful and easy to understand. But since maybe it won't be needed in the majority of the cases, I don't know if it should be also removed/hidden. -- You are receiving this mail because: You are watching all bug changes.
