https://bugs.kde.org/show_bug.cgi?id=447464
amyspark <a...@amyspark.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/fc362afcb |hics/krita/commit/de938cfc8
|2954d10f8391f803b44a4c2ac88 |9875c360a0e161b5de723739eed
|de39 |f2cc
--- Comment #6 from amyspark <a...@amyspark.me> ---
Git commit de938cfc89875c360a0e161b5de723739eedf2cc by L. E. Segovia, on behalf
of Sharaf Zaman.
Committed on 28/06/2022 at 19:52.
Pushed by lsegovia into branch 'krita/5.1'.
Bugfix: Gradient fill stops can't be changed for vector objects
What resulted in the bug is firing of selectionContentChanged() signal
after the setNewGradientBackgroundToShape() routine had returned --
because the blocker for d->shapeChangedAcyclicConnector had already been
destroyed. And when the shapeChanged method was called, it sent down the
call assuming gradient was changed (which would reset value of
m_selectedStop) when it wasn't.
Now, we remove signal connections for selectionChanged() and
selectionContentChanged(), because they're delivered asynchronously and
without proper guards (the signal blocker work only in some cases, e.g
on windows they always fire once the guard lifetime has ended).
Removing these signals is safe because we now use resourceManager
signals to update the UI once the underlying resource has changed.
Related: bug 455794, bug 449606, bug 453331
(cherry picked from commit fc362afcb2954d10f8391f803b44a4c2ac88de39)
M +2 -20 libs/ui/widgets/KoFillConfigWidget.cpp
https://invent.kde.org/graphics/krita/commit/de938cfc89875c360a0e161b5de723739eedf2cc
--
You are receiving this mail because:
You are watching all bug changes.
