https://bugs.kde.org/show_bug.cgi?id=456450
Dmitry Kazakov <dimul...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
|hics/krita/commit/39b5ef790 |hics/krita/commit/e1b32d773
|7fe22b120b572fc49887ae83bde |526983ee54a4edfafd146d30ff0
|16b5 |8b2a
--- Comment #5 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit e1b32d773526983ee54a4edfafd146d30ff08b2a by Dmitry Kazakov.
Committed on 08/07/2022 at 15:27.
Pushed by dkazakov into branch 'master'.
Fix a crash when D&D a vector layer from one image to another
The patch does several things
1) Removes "application/x-krita-node" mimedata completely. It was
used to pass Krita nodes between multiple instances of Krita. Since
we don't support multiinstance runs anymore, these types should go.
(they failed in multiple usecases anyway)
2) Implements a special KisDetachedShapesViewConverter converter class
that is attached to KisShapeLayerCanvasBase, when it has no image
attached (that was an exact cause of the crash). Now, when the
vector layer is placed into a mime data, its converter is replaced
with the detached one to no rely on KisImage (which is deleted at that
moment)
M +1 -0 libs/ui/CMakeLists.txt
A +19 -0 libs/ui/KisClonableViewConverter.h [License: GPL(v2.0+)]
A +56 -0 libs/ui/KisDetachedShapesViewConverter.cpp [License:
GPL(v2.0+)]
A +42 -0 libs/ui/KisDetachedShapesViewConverter.h [License:
GPL(v2.0+)]
M +13 -14 libs/ui/KisView.cpp
M +2 -2 libs/ui/KisWelcomePageWidget.cpp
M +1 -4 libs/ui/flake/KisReferenceImagesLayer.cpp
M +16 -7 libs/ui/flake/kis_shape_layer.cc
M +0 -1 libs/ui/flake/kis_shape_layer.h
M +48 -6 libs/ui/flake/kis_shape_layer_canvas.cpp
M +11 -5 libs/ui/flake/kis_shape_layer_canvas.h
M +2 -2 libs/ui/kis_clipboard.cc
M +4 -9 libs/ui/kis_image_view_converter.cpp
M +4 -8 libs/ui/kis_image_view_converter.h
M +33 -87 libs/ui/kis_mimedata.cpp
M +15 -12 libs/ui/kis_mimedata.h
M +1 -1 libs/ui/kis_node_model.cpp
https://invent.kde.org/graphics/krita/commit/e1b32d773526983ee54a4edfafd146d30ff08b2a
--
You are receiving this mail because:
You are watching all bug changes.
