https://bugs.kde.org/show_bug.cgi?id=456871
bionickatana <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://invent.kde.org/mult | |imedia/kdenlive/commit/6880 | |a0d21222706fb0b942d3a36e4eb | |b56696673 --- Comment #5 from bionickatana <[email protected]> --- Git commit 6880a0d21222706fb0b942d3a36e4ebb56696673 by Nathan Hinton, on behalf of Eric Jiang. Committed on 20/07/2022 at 22:14. Pushed by bionickatana into branch 'master'. Guess subtitle encoding before importing Since many subtitle files are not UTF-8, we need to guess the encoding of the file before reading it. For example, SubRip's default encoding is Windows-1252 (according to Wikipedia). This also adds KF5 Codecs as a dependency in order to use KEncodingProber. Future work could be done to allow the user to select the encoding in the import dialog. Currently there is no way to manually select the encoding if it's not guessed correctly, but this should at least be an improvement over only supporting UTF-8. M +1 -1 CMakeLists.txt M +1 -1 dev-docs/build.md M +40 -9 src/bin/model/subtitlemodel.cpp M +7 -1 src/bin/model/subtitlemodel.hpp M +8 -5 src/timeline2/view/timelinecontroller.cpp A +12 -0 tests/dataset/01-iso-8859-1.srt M +22 -2 tests/subtitlestest.cpp https://invent.kde.org/multimedia/kdenlive/commit/6880a0d21222706fb0b942d3a36e4ebb56696673 -- You are receiving this mail because: You are watching all bug changes.
