https://bugs.kde.org/show_bug.cgi?id=456873
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|DUPLICATE |FIXED
Latest Commit| |https://invent.kde.org/plas
| |ma/kwin/commit/a7520b3659d2
| |364d4c1e10246166243438ba084
| |e
--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit a7520b3659d2364d4c1e10246166243438ba084e by David Edmundson.
Committed on 27/07/2022 at 12:20.
Pushed by davidedmundson into branch 'master'.
Fix activity swtiching through UserActions menu
On wayland the code to keep windows on the current activity whilst the
window was broken was completely broken in porting. We only held the
block for the duration of the method even though the popup remained open
for longer.
On X11, when removing the window from the current activity it would not
update correctly and remain visible. The code path was as follows:
- the menu is shown an event loop is started
- we change the activities
- as we close the menu focus changes and workspace calls
UserActionsMenu::close this unsets m_window
- We then never call the blockActivityUpdates(false) at the end of
UserActionsMenu::show
This patch addresses both at once.
We get rid of the nested event loop as that was always evil. This means
slotWindowOperation no longer needs to be queued.
We perform cleanup of m_window and the activity blocker when the menu
closes which should be safer.
M +15 -11 src/useractions.cpp
M +8 -0 src/useractions.h
https://invent.kde.org/plasma/kwin/commit/a7520b3659d2364d4c1e10246166243438ba084e
--
You are receiving this mail because:
You are watching all bug changes.
