https://bugs.kde.org/show_bug.cgi?id=459455
vanyossi <ghe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://invent.kde.org/grap
| |hics/krita/commit/ae8371b9b
| |310164c4db99c03c7da0c8e844e
| |9519
--- Comment #5 from vanyossi <ghe...@gmail.com> ---
Git commit ae8371b9b310164c4db99c03c7da0c8e844e9519 by Ivan Yossi.
Committed on 28/09/2022 at 22:29.
Pushed by ivany into branch 'master'.
Allow adding more than 1 blank keyframe
Allows to add blank animation layers as the selection.
I talked briefly with emmet about this and it could be a good addition for some
workflow cases. However it needs a bit of UI testing, so before fixing the
issues I need to test a bit if the change is indeed feels ok with the workflow
design we have for animations.
As it is now I think it needs polish, i.e. If the current layer is locked and
the selection goes beyond more than one layer no blank layer is added. if
current layer is no locked it will ad blank frames on non locked frames. Which
is inconsistent.
- [x] I confirmed this builds.
- [ x] I confirmed Krita ran and the relevant functions work.
- [ x] I tested the relevant unit tests and can confirm they are not broken.
(If not possible, don't hesitate to ask for help!)
- [ x] I made sure my commits build individually and have good descriptions as
per [KDE guidelines](https://community.kde.org/Policies/Commit_Policy).
- [x] I made sure my code conforms to the standards set in the HACKING file.
- [ x] I can confirm the code is licensed and attributed appropriately, and
that unattributed code is mine, as per [KDE Licensing
Policy](https://community.kde.org/Policies/Licensing_Policy).
M +30 -3 plugins/dockers/animation/KisAnimTimelineFramesModel.cpp
M +1 -1 plugins/dockers/animation/KisAnimTimelineFramesModel.h
M +7 -6 plugins/dockers/animation/KisAnimTimelineFramesView.cpp
https://invent.kde.org/graphics/krita/commit/ae8371b9b310164c4db99c03c7da0c8e844e9519
--
You are receiving this mail because:
You are watching all bug changes.
