https://bugs.kde.org/show_bug.cgi?id=456835
Fushan Wen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In| |5.26 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit| |https://invent.kde.org/plas | |ma/plasma-workspace/commit/ | |5b7c5a201dc2517a5545a7017ca | |f10bf78dde335 --- Comment #4 from Fushan Wen <[email protected]> --- Git commit 5b7c5a201dc2517a5545a7017caf10bf78dde335 by Fushan Wen, on behalf of Tanbir Jishan. Committed on 05/10/2022 at 23:33. Pushed by fusionfuture into branch 'master'. kcms/colors: Fix color previews not updating until apply is pressed The reason colors are not updating correctly because there is no color(valid) to show in the first place. The color generation was later disabled when setting is not from wallpaper after the feature being implemented, I guess for efficiency. So we need to temporarily turn on the color engine, take the color and then again disable it. There is two reason for which we should always return a valid color for primary desktop: 1. We need to show the preview when asked. 2. There is a public dbus api which was added so that any third party code can get the correct wallpaper accent color any moment, regardless of setting. This may be useful, for example some app which always want to show some ui element in the wallpaper color. FIXED-IN: 5.26 M +41 -2 shell/shellcorona.cpp M +2 -0 shell/shellcorona.h https://invent.kde.org/plasma/plasma-workspace/commit/5b7c5a201dc2517a5545a7017caf10bf78dde335 -- You are receiving this mail because: You are watching all bug changes.
