https://bugs.kde.org/show_bug.cgi?id=368462
Steven Noonan <ste...@uplinklabs.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ste...@uplinklabs.net
--- Comment #1 from Steven Noonan <ste...@uplinklabs.net> ---
Created attachment 101135
--> https://bugs.kde.org/attachment.cgi?id=101135&action=edit
NON-PRODUCTION PATCH - implement recognition of ECC key types
Attached a patch (against v16.08.1) which makes it at least recognize the key
types. But I strongly recommend *against* including the patch as-is. The
_gpgme_map_pk_algo function I threw in there is basically just a rip of the
non-exported function of the same name from here:
https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=commitdiff;h=c4b6b35bfa98e478f1d13f4ce3e664771f2604c2
It does the job, but KGPG shouldn't be responsible for converting OpenPGP
algorithm identifiers into GPGME algorithm identifiers. It seems to me that
KGPG should just be using the key listing APIs:
https://www.gnupg.org/documentation/manuals/gpgme/Listing-Keys.html#Listing-Keys
But it looks like KGPG doesn't link to gpgme and only uses the gpgme_validity_t
type from gpgme.h?
This patch also does not take care of adding ECC key generation, and there are
9 different curves to choose from, so that means at least another dropdown in
the key generation dialog. ;)
--
You are receiving this mail because:
You are watching all bug changes.
