https://bugs.kde.org/show_bug.cgi?id=442176

Nate Graham <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
                   |imedia/elisa/commit/f47edcc |imedia/elisa/commit/1f5b57e
                   |1bf4a0483a679f58595a71814b6 |8e1c3019c4ab00d6d1eba5ddd6b
                   |b19182                      |3feb8b

--- Comment #8 from Nate Graham <[email protected]> ---
Git commit 1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b by Nate Graham, on behalf
of Jack Hill.
Committed on 12/01/2023 at 21:01.
Pushed by ngraham into branch 'release/22.12'.

Fix Recently and Frequently Played sort buttons

The sortRole for both views were being changed to TitleRole, since each
view is track-based (i.e. they display tracks, as opposed to albums,
artists, etc.). I think the function responsible for this exists for
future purposes when users will be able to switch between grid/list
views manually.

Solution to is to just hardcode the sortRole and sortOrder of each view.
This also fixes the problem where the sort menu had no text.

Note that the sorting for "Frequently Played" currently does sort purely
based on each tracks' play count. This will be addressed elsewhere.
FIXED-IN: 21.12.2


(cherry picked from commit f449f49aca4188f09dbb3d9aab69e97783ddcee3)

M  +25   -6    src/viewmanager.cpp
M  +2    -2    src/viewmanager.h

https://invent.kde.org/multimedia/elisa/commit/1f5b57e8e1c3019c4ab00d6d1eba5ddd6b3feb8b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to