https://bugs.kde.org/show_bug.cgi?id=354301

Elvis Angelaccio <elvis.angelac...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/dolp
                   |                            |hin/3775ef19eaca057985b92cf
                   |                            |a3716d3c3a1d22f0f
   Version Fixed In|                            |16.08.2

--- Comment #5 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit 3775ef19eaca057985b92cfa3716d3c3a1d22f0f by Elvis Angelaccio.
Committed on 21/09/2016 at 16:13.
Pushed by elvisangelaccio into branch 'Applications/16.08'.

Properly check Shift toggling in DolphinRemoveAction

Documentation of QGuiApplication::keyboardModifiers() says that "It should
be noted this may not reflect the actual keys held on the input device at
the time of calling but rather the modifiers as last reported in one of
the above events".

Since this method is called in DolphinContextMenu's keyPressEvent()
and keyReleaseEvent(), the first time that keyboardModifiers() is
called it doesn't report that shift has been pressed.

Replacing this method with queryKeyboardModifiers() does the job
because the latter doesn't care about the event queue.
FIXED-IN: 16.08.2
REVIEW: 128972

M  +1    -1    src/dolphinremoveaction.cpp

http://commits.kde.org/dolphin/3775ef19eaca057985b92cfa3716d3c3a1d22f0f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to