https://bugs.kde.org/show_bug.cgi?id=367995
Philippe Waroquiers <philippe.waroqui...@skynet.be> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |philippe.waroquiers@skynet.
| |be
--- Comment #14 from Philippe Waroquiers <philippe.waroqui...@skynet.be> ---
Quickly read the last version of the patch, sorry for entering in the game so
late
Some comments:
* Typo in the xml documentation: alocator
* lines like below: opening brace should be on the same line
+ if (MC_(is_mempool_block)(ch1))
+ {
* for detecting/reporting/asserting the overlap condition
in case ch1_is_meta != ch2_is_meta, I am wondering if we should not check
that the non meta block is (fully) inside the meta block.
It looks to be an error if the non meta block is not fully inside the meta
block.
* free_mallocs_in_mempool_block : this looks to be an algorithm that will be
O (n * m) when n is the nr of malloc-ed blocks, and m is the nr of blocks
covered
by Start/End address. That might be very slow for big applications, that
allocates millions
of blocks, e.g. 1 million normal block, and one million blocks in meta
blocks
will take a lot of time to cleanup ?
Thanks
--
You are receiving this mail because:
You are watching all bug changes.
