https://bugs.kde.org/show_bug.cgi?id=463853

Fushan Wen <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/commit/
                   |                            |a521f5ada3dadbe938c662a607a
                   |                            |a28737530bd8e
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Version Fixed In|                            |6

--- Comment #7 from Fushan Wen <[email protected]> ---
Git commit a521f5ada3dadbe938c662a607aa28737530bd8e by Fushan Wen, on behalf of
Alessio Bonfiglio.
Committed on 25/01/2023 at 03:53.
Pushed by fusionfuture into branch 'master'.

Make clocks tooltip consistent and add seconds

Having the seconds visible in your clock widget can be distracting, so most
people decide to keep them hidden. Sometimes though it happens that you may
need to know them: the idea  behind this mr is to make them always available in
the tooltip of the clock widgets. And also make these tooltips consistent with
each others as a bonus.

Unfortunately I'm no expert with qml, and I got stuck trying to accessing the
tooltip inside the widget qml sources. I need to know when the tooltip is shown
in order to change the sampling time and the alignment type of the time
datasource. In the case of the digital clock, I can get that through
`Plasmoid.toolTipItem.visible` because a custom tooltip is used, but in the
analog clock this isn't the case and so `Plasmoid.toolTipItem` doesn't
reference anything. I'd need to access the `visible` property of the
`ToolTipDialog` currently in use, and probably a good solution would be to
connect that to a new signal in `appletinterface`, but I haven't even
understood how that is, for example, connected to the `ToolTip` class for
example, so any help/suggestion would be welcomed.
Otherwise I could make a custom tooltip in the analog clock too and use the
same trick as for the digital one, but it sounds more like a hack than a
solution.

PS: As soon as I fix the problem above I'll take care of the fuzzy and binary
clocks too.
FIXED-IN: 6

M  +2    -1    applets/analog-clock/contents/ui/analogclock.qml
M  +3    -3    applets/digital-clock/package/contents/config/main.xml
M  +4    -2    applets/digital-clock/package/contents/ui/CalendarView.qml
M  +6    -6    applets/digital-clock/package/contents/ui/DigitalClock.qml
M  +5    -3    applets/digital-clock/package/contents/ui/Tooltip.qml
M  +23   -4    applets/digital-clock/package/contents/ui/configAppearance.qml
M  +12   -4    applets/digital-clock/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/a521f5ada3dadbe938c662a607aa28737530bd8e

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to