https://bugs.kde.org/show_bug.cgi?id=466524

michael <reeves...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/sdk/ |https://invent.kde.org/sdk/
                   |kdiff3/commit/7b7e556970bbc |kdiff3/commit/119648a3102f5
                   |85a920021f61d33afc816eea30e |f21074cc3c181045e209eefcfe3

--- Comment #4 from michael <reeves...@gmail.com> ---
Git commit 119648a3102f5f21074cc3c181045e209eefcfe3 by Michael Reeves.
Committed on 27/02/2023 at 23:09.
Pushed by mreeves into branch 'master'.

Don't convert std::shared_ptr<Diff3Line> to a bare pointer

This prevents use after free reported in
https://bugs.kde.org/show_bug.cgi?id=466524

In addition reset all three DiffTextWindows and MergeResultWindow on reload.
This fixes a second bad memmory access visable in the valgrind log.
FIXED-IN:10.0.1

M  +1    -1    src/diff.cpp
M  +2    -2    src/diff.h
M  +7    -7    src/difftextwindow.cpp
M  +2    -0    src/mergeresultwindow.cpp
M  +0    -5    src/mergeresultwindow.h
M  +6    -2    src/pdiff.cpp

https://invent.kde.org/sdk/kdiff3/commit/119648a3102f5f21074cc3c181045e209eefcfe3

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to