https://bugs.kde.org/show_bug.cgi?id=360333
--- Comment #23 from Guillaume Martres <smar...@ubuntu.com> ---
(In reply to Anthony Vital from comment #22)
> Could the problem be the method used to scale the icon size on hidpi
> monitors?
> Looking in plasma-framework/src/declarativeimports/core/units.cpp:
> // Scale the icon sizes up using the devicePixelRatio
> // This function returns the next stepping icon size
> // and multiplies the global settings with the dpi ratio.
> const qreal ratio = devicePixelRatio();
>
> if (ratio < 1.5) {
> return size;
> } else if (ratio < 2.0) {
> return size * 1.5;
> } else if (ratio < 2.5) {
> return size * 2.0;
> } else if (ratio < 3.0) {
> return size * 2.5;
> } else if (ratio < 3.5) {
> return size * 3.0;
> } else {
> return size * ratio;
> }
> My ratio is 1.47674, that means I have no scaling at all when there is a 1.5
> factor existing. Is it reasonable? Wouldn't it make more sense to use the
> factor the closest to the ratio rather than what is done here?
Good point, but even if you fix that, I think that devicePixelRatio() will
still return 1 because of:
qunsetenv("QT_DEVICE_PIXEL_RATIO");
QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling)
in
https://quickgit.kde.org/?p=plasma-workspace.git&a=blob&h=ec117f3bf9c12894bc7d3f80858256fab0026da4&hb=e88b52a18ff9c7ed43a9bed4e4ba270a8ee18355&f=shell%2Fmain.cpp
(cf https://bugs.kde.org/show_bug.cgi?id=356446)
--
You are receiving this mail because:
You are watching all bug changes.
