https://bugs.kde.org/show_bug.cgi?id=368989

Martin Gräßlin <mgraess...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |http://commits.kde.org/kwin
                   |                            |/421824b654a5301fe1c0ed97ca
                   |                            |ded66936c91385
   Version Fixed In|                            |5.8.1

--- Comment #10 from Martin Gräßlin <mgraess...@kde.org> ---
Git commit 421824b654a5301fe1c0ed97caded66936c91385 by Martin Gräßlin.
Committed on 06/10/2016 at 11:28.
Pushed by graesslin into branch 'Plasma/5.8'.

Workaround xkbcommon behavior concerning consumed modifiers

Summary:
If a key could be turned into a keysym with a modifier xkbcommon
considers the modifier as consumed even if not pressed.
E.g. Alt+F3 considers alt as consumed as there is a keysym gnerated with
Ctrl+Alt+F3 (vt switching).

This change tries to workaround the problem by ignoring the consumed
modifiers if there are more modifiers consumed than active. It's
possible that this will create regressions for other shortcuts - we need
to test it in the wild. Although this might cause regressions I'm aiming
for Plasma/5.8 branch with the change. It only affects Wayland and fixes
quite important shortcuts from window manager perspective (desktop
switching (ctrl+f1 to ctrl+f4), desktop grid (ctrl+f8), present windows
(ctrl+f9, ctrl+10), cube (ctrl+f11), user actions (alt+f3), close window
(alt+f4)). If it causes regressions they need to be fixed as well in the
Plasma/5.8 branch.

A new API entry point for xkbcommon was proposed, but is not yet merged
and there is no release with it yet. Once that is available the
workaround should get removed and replaced by the new API call.
FIXED-IN: 5.8.1

Test Plan: Going to restart session now with the change

Reviewers: #kwin, #plasma_on_wayland

Subscribers: plasma-devel, kwin

Tags: #plasma_on_wayland, #kwin

Differential Revision: https://phabricator.kde.org/D2945

M  +0    -1    autotests/integration/globalshortcuts_test.cpp
M  +18   -0    keyboard_input.cpp

http://commits.kde.org/kwin/421824b654a5301fe1c0ed97caded66936c91385

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to