https://bugs.kde.org/show_bug.cgi?id=339863
Felix Ernst <felixer...@kde.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram |eworks/kwidgetsaddons/-/com |eworks/kwidgetsaddons/-/com |mit/e5ef8184db0733b944cb7a3 |mit/2273405379815ce9a4c6561 |c9ee1cf239035921b |9511849c3aa3b5a84 --- Comment #68 from Felix Ernst <felixer...@kde.org> --- Git commit 2273405379815ce9a4c65619511849c3aa3b5a84 by Felix Ernst, on behalf of Felix Ernst. Committed on 11/09/2023 at 09:25. Pushed by felixernst into branch 'kf5'. Fix file rating being unreadable in certain themes Typically, a rating on a file is represented by five stars in a row. If the first 3 stars are filled and the other 2 aren't, that represents a 3/5 star rating. When a theme only provides the filled stars (i.e. "rating") icon but no unfilled stars (i.e. "rating-unrated") icon, KRatingPainter would always paint all five stars as filled no matter if the actual rating was 1/5 or 5/5 because the automatic fallback of the "rating-unrated" icon is the "rating" icon as stated by the icon theme spec. This commit fixes this by having KRatingPainter use a generated replacement "rating-unrated" icon (a de-saturated and grey-scaled "rating" icon), if the theme does not provide a "rating-unrated" icon already. (cherry picked from commit e5ef8184db0733b944cb7a3c9ee1cf239035921b) M +10 -6 src/kratingpainter.cpp https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/2273405379815ce9a4c65619511849c3aa3b5a84 -- You are receiving this mail because: You are watching all bug changes.