https://bugs.kde.org/show_bug.cgi?id=474583

            Bug ID: 474583
           Summary: Swatchbooker CMYK color palette may be rendered
                    incorrectly
    Classification: Applications
           Product: krita
           Version: 5.2.0-rc1
          Platform: Other
                OS: Other
            Status: REPORTED
          Severity: minor
          Priority: NOR
         Component: File formats
          Assignee: krita-bugs-n...@kde.org
          Reporter: cmyk.stud...@gmail.com
  Target Milestone: ---

Created attachment 161652
  --> https://bugs.kde.org/attachment.cgi?id=161652&action=edit
Swatchbooker palette loaded in GIMP, with Cyan row highlighted

GIMP recently added support for importing Swatchbooker color palettes. While
comparing the results with Krita, I noticed that Krita might be rendering the
CMYK colors incorrectly. In the sample file from the Swatchbooker repository,
there is a row of "Cyan (%)" colors that are in the CMYK color space. In GIMP,
these show up as Cyan (see attached image). In Krita, they show up as white.

Swatchbooker stores the CMYK percentages as floating point (0.0 to 1.0). I
think what's happening is that Krita is treating those as 0.5% rather than
multiplying them to get 50.0% 
The relevant code for Krita is at
https://invent.kde.org/graphics/krita/-/blob/master/libs/pigment/resources/KoColorSet.cpp#L1832

(Note that Krita does have a test .sbz file at
https://invent.kde.org/graphics/krita/-/blob/master/libs/pigment/tests/data/swatchbook.sbz,
but the "CMYK" palette is commented out from the Swatchbooker site example and
replaced with RGB).


STEPS TO REPRODUCE
1. Download a valid .sbz file with a CMYK color palette
(https://github.com/olivierberten/SwatchBooker/blob/master/data/sample.sbz)
2. Import into Krita
3. Look at the "Cyan" colors in the palette

OBSERVED RESULT
The "Cyan" colors appear to be white

EXPECTED RESULT
The "Cyan" colors should be Cyan

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to