https://bugs.kde.org/show_bug.cgi?id=473214
ratijas <m...@ratijas.tk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/kirigami/-/commit/74
| |e6a852d2f55ad9c53f34972fe3b
| |a0c1ad78c42
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #12 from ratijas <m...@ratijas.tk> ---
Git commit 74e6a852d2f55ad9c53f34972fe3ba0c1ad78c42 by ivan tkachenko.
Committed on 18/10/2023 at 12:13.
Pushed by ratijas into branch 'master'.
AbstractApplication*: Fix reparenting of drawers, Clean up bindings
Querying T.Overlay.overlay attached property on a Binding object was
clearly wrong. It just resulted in null at all times, so basically
those Bindings never took effect.
Since `when:` condition does not make much sense (first, those
properties could never be undefined; second, why reparenting only when
visible?), let's demote them into a property change handlers with null
guards.
For other bindings, pointless `when` check was removed as well as
deprecated (and yet again pointless) restoreMode.
Co-Authored-By: Jack Hill <jackhill3...@gmail.com>
M +61 -1 autotests/tst_globaldrawer.qml
M +21 -37 src/controls/AbstractApplicationItem.qml
M +24 -26 src/controls/AbstractApplicationWindow.qml
https://invent.kde.org/frameworks/kirigami/-/commit/74e6a852d2f55ad9c53f34972fe3ba0c1ad78c42
--
You are receiving this mail because:
You are watching all bug changes.
