https://bugs.kde.org/show_bug.cgi?id=370265
Mark Wielaard <m...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@redhat.com
--- Comment #3 from Mark Wielaard <m...@redhat.com> ---
This updates the min_power_isa check to accept 3.00 instead of 3.0, but the
vbit test still uses 3.0 causing test failures in
memcheck/tests/vbit-test/vbit-test:
ERROR: invalid ISA version. Valid versions numbers are:
2.05, 2.06, 2.07, 3.00
I tested the following fix on gcc112.fsffrance.org a ppc64le (power8) setup:
diff --git a/memcheck/tests/vbit-test/irops.c
b/memcheck/tests/vbit-test/irops.c
index 67e6e47..5b1106a 100644
--- a/memcheck/tests/vbit-test/irops.c
+++ b/memcheck/tests/vbit-test/irops.c
@@ -1287,8 +1287,8 @@ get_irop(IROp op)
case Iop_MulI128by10Carry:
case Iop_MulI128by10E:
case Iop_MulI128by10ECarry: {
- /* IROps require a processor that supports ISA 2.07 (Power 8) or
newer */
- rc = system(MIN_POWER_ISA " 3.0 ");
+ /* IROps require a processor that supports ISA 3.00 (Power 9) or
newer */
+ rc = system(MIN_POWER_ISA " 3.00 ");
rc /= 256;
/* MIN_POWER_ISA returns 0 if underlying HW supports the
* specified ISA or newer. Returns 1 if the HW does not support
diff --git a/tests/min_power_isa.c b/tests/min_power_isa.c
index e4035ce..37d89f5 100644
--- a/tests/min_power_isa.c
+++ b/tests/min_power_isa.c
@@ -64,7 +64,7 @@ int main(int argc, char **argv)
return !(isa_level >= 8);
} else {
- fprintf(stderr, "ERROR: invalid ISA version. Valid versions numbers
are:\n" );
+ fprintf(stderr, "ERROR: invalid ISA version '%s'. Valid versions
numbers are:\n", min_isa );
fprintf(stderr, " 2.05, 2.06, 2.07, 3.00\n" );
exit(2);
}
--
You are receiving this mail because:
You are watching all bug changes.
