https://bugs.kde.org/show_bug.cgi?id=467092
--- Comment #29 from Nate Graham <n...@kde.org> --- Git commit 1c8a4d1e46b9a519ab6576d3b9829eb611c5c9a5 by Nate Graham, on behalf of Harald Sitter. Committed on 08/11/2023 at 21:27. Pushed by ngraham into branch 'master'. foldermodel: lift screen add/remove handling out of screenmapper screenmapper is the wrong place for it because we don't know the url inside the mapper. Instead handle events in the foldermodel and correctly delegate the add/remove actions to the mapper with both our screenId AND the activityId notably the previous code would incorrectly invoke addScreen with empty activityIds triggering fallback handling that resulted in incorrect m_screensPerPath management (there would be no screen associated with our url anymore after a screenAdded signal because our screen got associated with no url) and consequently firstAvailableScreen would return no screen for our url (remember: we are associated with no url) making FolderModel::filterAcceptsRow return false and filtering completely valid entries Related: bug 467951 possibly also is the root cause behind M +11 -1 containments/desktop/plugins/folder/foldermodel.cpp M +1 -8 containments/desktop/plugins/folder/screenmapper.cpp M +1 -1 containments/desktop/plugins/folder/screenmapper.h https://invent.kde.org/plasma/plasma-desktop/-/commit/1c8a4d1e46b9a519ab6576d3b9829eb611c5c9a5 -- You are receiving this mail because: You are watching all bug changes.
