https://bugs.kde.org/show_bug.cgi?id=465266
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/plas
| |ma/plasma-workspace/-/commi
| |t/2be90db50bd369d44a567e364
| |2ec98deca21187c
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 2be90db50bd369d44a567e3642ec98deca21187c by David Edmundson.
Committed on 28/11/2023 at 11:50.
Pushed by davidedmundson into branch 'master'.
Fix most of the lock screen
The commit introduced the idea of tying the UI to the authentication
state. Starting and cancelling as the UI became visible.
Whilst nice on paper this had two critical bugs:
- cancelling an interactive authentication leads to an entry in the
faillock list. This means pressing escape 3 times in quick successsion
could lock you out your account for 10 minutes.
- There was a concept of a failed state, which wasn't handled in the UI
properly leading to prompts disappearing.
The notification about the failed lock could not be seen.
It also failed to handle the prompts correctly, we had multiple things
bound to the same root.notification completely ignoring the
handleMessage function which is trying to stack messages.
This reverts some of commit 59cdc995e738a0b1cd734e2d1be19e87db99f32b,
but keeps the core feature.
Related: bug 477326
M +2 -0 lookandfeel/components/WallpaperFader.qml
M +22 -17 lookandfeel/org.kde.breeze/contents/lockscreen/LockScreenUi.qml
https://invent.kde.org/plasma/plasma-workspace/-/commit/2be90db50bd369d44a567e3642ec98deca21187c
--
You are receiving this mail because:
You are watching all bug changes.
