https://bugs.kde.org/show_bug.cgi?id=478519

Dmitry Kazakov <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/krita/-/commit/45491cd
                   |                            |ab843c617e35983534fafbf81ad
                   |                            |900f0a
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED

--- Comment #3 from Dmitry Kazakov <[email protected]> ---
Git commit 45491cdab843c617e35983534fafbf81ad900f0a by Dmitry Kazakov.
Committed on 11/01/2024 at 11:22.
Pushed by dkazakov into branch 'master'.

Fix inconsistent undo/redo of select/deselect/reselect actions

Before the patch, the global selection actions operated with a
raw selection object, not with a selection mask. It caused issues,
when the user manually converted/moved the global selection mask
into another position.

The patch changes this behavior and makes the selection commands
operate with the entire selection mask, which makes operations
consistent.
Related: bug 478520

M  +1    -1    krita/kritamenu.action
M  +2    -0    libs/image/CMakeLists.txt
A  +24   -0    libs/image/KisImageGlobalSelectionManagementInterface.h    
[License: GPL(v2.0+)]
A  +39   -0    libs/image/commands/KisChangeDeselectedMaskCommand.cpp    
[License: GPL(v2.0+)]
A  +31   -0    libs/image/commands/KisChangeDeselectedMaskCommand.h    
[License: GPL(v2.0+)]
A  +21   -0    libs/image/commands/KisNotifySelectionChangedCommand.cpp    
[License: GPL(v2.0+)]
A  +24   -0    libs/image/commands/KisNotifySelectionChangedCommand.h    
[License: GPL(v2.0+)]
M  +18   -18   libs/image/commands/kis_deselect_global_selection_command.cpp
M  +3    -6    libs/image/commands/kis_deselect_global_selection_command.h
M  +25   -25   libs/image/commands/kis_reselect_global_selection_command.cpp
M  +3    -6    libs/image/commands/kis_reselect_global_selection_command.h
M  +36   -11   libs/image/commands/kis_set_global_selection_command.cpp
M  +3    -3    libs/image/commands/kis_set_global_selection_command.h
M  +22   -44   libs/image/kis_image.cc
M  +7    -26   libs/image/kis_image.h
M  +11   -7    libs/image/tests/kis_image_test.cpp
M  +4    -2    libs/libkis/Document.cpp
M  +1    -0    libs/ui/kis_action.h
M  +4    -0    libs/ui/kis_action_manager.cpp
M  +30   -9    libs/ui/kis_selection_manager.cc
M  +1    -0    libs/ui/kis_selection_manager.h

https://invent.kde.org/graphics/krita/-/commit/45491cdab843c617e35983534fafbf81ad900f0a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to