https://bugs.kde.org/show_bug.cgi?id=393080

Tuomas Nurmi <tuo...@norsumanageri.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/mult
                   |                            |imedia/amarok/-/commit/8db1
                   |                            |762e7d859aaebb45dd53edeac14
                   |                            |c99b27a37
             Status|ASSIGNED                    |RESOLVED

--- Comment #16 from Tuomas Nurmi <tuo...@norsumanageri.org> ---
Git commit 8db1762e7d859aaebb45dd53edeac14c99b27a37 by Tuomas Nurmi.
Committed on 23/03/2024 at 12:17.
Pushed by nurmi into branch 'master'.

Fix crash in PodcastSettingsDialog initialization.

Although a box including an Apply button was created, it was not actually set
as the button box for the dialog, and trying to access an Apply button through
buttonBox() thus always resulted in null.
Additionally, make the UI work by converting the setup to actually use the
functionality provided by KPageDialog. Also remove the connection of accepted
and rejected signals, as according to API docs, they are created automatically.

M  +3    -3    ChangeLog
M  +2    -5    src/core-impl/podcasts/sql/PodcastSettingsDialog.cpp

https://invent.kde.org/multimedia/amarok/-/commit/8db1762e7d859aaebb45dd53edeac14c99b27a37

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to