https://bugs.kde.org/show_bug.cgi?id=486665

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/-/commi
                   |                            |t/bf8545946cc340c262911c0ba
                   |                            |94e28661a7feb8a
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit bf8545946cc340c262911c0ba94e28661a7feb8a by Kai Uwe Broulik.
Committed on 14/05/2024 at 12:30.
Pushed by broulik into branch 'master'.

Notifications: Restore custom DragHelper

When the notification popup closes, the ListView mode is unloaded to
save some resources. On Wayland, during drag and drop another window
might be raised and focussed causing the notification popup to close.

QtQuick's built-in drag handling does not take kind to having the
item it's operating on destroyed behind its back, particularly because
it uses a freaking' nested event loop inside of dragStarted!

Restore the original DragHandler which detaches the drag operation
entirely from the item that triggered it. It also creates a proper
drag pixmap for dragging the file icon and keeps it for the entire
duration of the drag.

As a bonus this also lets us export the URL to the Document portal
to enable drag and drop of thumbnails to sandboxed apps.
Related: bug 484546

M  +3    -0    applets/notifications/CMakeLists.txt
A  +84   -0    applets/notifications/draghelper.cpp     [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
A  +42   -0    applets/notifications/draghelper.h     [License: GPL(3+eV)
GPL(v3.0) GPL(v2.0)]
M  +4    -0    applets/notifications/notificationapplet.cpp
M  +10   -9    applets/notifications/package/contents/ui/DraggableFileArea.qml
M  +2    -5    applets/notifications/package/contents/ui/JobItem.qml
M  +2    -5    applets/notifications/package/contents/ui/ThumbnailStrip.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/bf8545946cc340c262911c0ba94e28661a7feb8a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to