https://bugs.kde.org/show_bug.cgi?id=372872
Bug ID: 372872 Summary: Possible Null-Pointer dereference in AlbumManager [patch] Product: digikam Version: 5.4.0 Platform: Compiled Sources OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: Searches-Fuzzy Assignee: digikam-de...@kde.org Reporter: mario.fr...@uni-potsdam.de Target Milestone: --- Created attachment 102429 --> https://bugs.kde.org/attachment.cgi?id=102429&action=edit Patch for the possible NULL Pointer derefernce As reported by coverty scan: *** CID 1394671: Null pointer dereferences (FORWARD_NULL) /home/gilles/Devel/5.x/core/libs/album/albummanager.cpp: 2080 in Digikam::AlbumManager::findSAlbumsBySearchType(int) const() 2074 2075 QList<SAlbum*> AlbumManager::findSAlbumsBySearchType(int searchType) const 2076 { 2077 QList<SAlbum*> albums; 2078 for (Album* album = d->rootSAlbum->firstChild(); album; album = album->next()) 2079 { >>> CID 1394671: Null pointer dereferences (FORWARD_NULL) >>> Assigning: "sAlbum" = "dynamic_cast <Digikam::SAlbum *>(album)". 2080 SAlbum* sAlbum = dynamic_cast<SAlbum*>(album); 2081 if (sAlbum->searchType() == searchType) 2082 { 2083 albums.append(sAlbum); 2084 } 2085 } As I understand that, either firstChild() may return NULL which is processed by dynamic_cast and this may also return NULL. I prevent that by explicitly checking for NULL. -- You are receiving this mail because: You are watching all bug changes.